Nested structures in C [was Re: svn commit: samba r18030 - in branches/SAMBA_3_0/source/tdb/common]

[Andrew Bartlett]

On Mon, 2006-09-04 at 19:37 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> vlendec at samba.org wrote:
> > Author: vlendec
> > Date: 2006-09-04 10:12:04 +0000 (Mon, 04 Sep 2006)
> > New Revision: 18030
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18030
> > 
> > Log:
> > When compiling with C++, nested structs lead to 
> > nested class definitions which are not compatible. I am
> > aware that this would be a huge change in Samba4, but
> > I would like to see it in the code that is shared.
> > 
> > Stefan, when you do merge work, can you get this 
> > across to Samba4?
> 
> Hey Volker,
> 
> I've got to agree with tridge here.  These kind of things
> are just not going to go away.  The entire autogenerated
> code from pidl uses the nested structure convention.
> And we're about to get a lot more of that in Samba 3.

I think I'm glad I never got into this thread, but I am a bit worried
where this 'C++ warning game' is headed.

While I think that 'class' and 'private' are perfectly good variable
names, and it is a shame to loose them, I'm not too worried about that.
I'm more worried about the other changes that seemed to be following,
and this would seem to be just the next in a long line...  

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060905/1420a598/attachment.bin