testsuite changes

tridge at samba.org tridge at samba.org
Wed Oct 18 23:01:44 GMT 2006


A quick question about some of the recent test suite changes.

Looking at the talloc test suite, it now runs a child process and
execs bin/torture/LOCAL/TALLOC whereas it previously ran the test
suite directly. This has a few consequences:

 - it means the talloc test suite is no longer run under valgrind on
   our valgrind test host

 - you can't easily run the test under gdb

 - it makes profiling and code coverage testing harder

 - we get no output showing (for example) the speed of talloc vs
   malloc, or any of the other output

I think that at least for the test suites that are written in C, I
much prefer the old method of calling the test code directly from

Perhaps we could have a convention of passing in a logging function
instead?  For example:

int talloc_testsuite(void *ctx, void (*logfn)(void *ctx, const char *fmt, ...))

and have the old #if _SAMBA_BUILD_ with main() in it 

Cheers, Tridge

More information about the samba-technical mailing list