libreplace vs. PARANOID_MALLOC_CHECKER

[Love Hörnquist Åstrand]

James, Tridge

>> Now, obviously this case is fixable, but IMO the #ifdef'ery  
>> performed by
>> libreplace is fragile and likely to keep stumbling over similar
>> breakage. Is there any reason why I can't have libreplace provide  
>> a real
>> symbol named strndup(), without the #define or any other funny  
>> business?
>
> We used to use the non-define approach, and hit just as many
> problems. Jelmer proposed that the define approach was less
> problematic and we switched to that.

This is my experice too, stomping on other's name-space is never a  
good thing
and will come back and bite you later.

Love