svn commit: samba r19126 - in branches/SAMBA_3_0/source/lib/socket_wrapper: .

Stefan (metze) Metzmacher metze at samba.org
Fri Oct 6 15:49:46 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker Lendecke schrieb:
> On Fri, Oct 06, 2006 at 05:09:20PM +0200, Stefan (metze) Metzmacher wrote:
>> please merge that to samba4:-)
> 
> Just FYI: I'm never sure if you did not mean it this way,
> that's why I'm not touching the 4_0 source code without
> request. I'm just rather careful with compiler warnings in
> Samba 3_0, I just find them annoying. And if there are too
> many, it is just too easy to miss the important ones.

I know!

I think we should change TDB_DATA to use unsigned char *
so that we get the same warnings in samba 3 and 4.

But we need to fix all callers in samba3...

If accepted I would create a patch for that.

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFJnsam70gjA5TCD8RAiigAKCZERVe1hnXnNFfULt4OtRhYXk9kgCgqr+a
ggiK4mtbo7R5ENp1+z3rQLg=
=FH8n
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list