asq.c checker error

simo idra at samba.org
Fri Oct 6 12:53:05 GMT 2006


On Fri, 2006-10-06 at 16:45 +1000, tridge at samba.org wrote:
> Simo,
> 
> Can you have a look at the switch statement in asq_wait_none() ? The
> first case seems to be missing either a break or a return, but I don't
> understand this code well enough to see which :)

Neither.
The statements prepares the set of calls to be done.
They are all done inside the second statement, so the first one need to
fall in the second. The second will return if an operation is not
performed immediately. (see the == LDB_ASYNC_DONE comparison).

I will add a comment to explain that.
Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-technical mailing list