gdb_backtrace fix 2

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Oct 6 10:04:25 GMT 2006


On Fri, Oct 06, 2006 at 10:36:42AM +0200, Björn JACKE wrote:
> ===================================================================
> --- source/script/tests/gdb_backtrace	(Revision 19117)
> +++ source/script/tests/gdb_backtrace	(Arbeitskopie)
> @@ -7,7 +7,7 @@
>  
>  BASENAME=`basename $0`
>  
> -test -z ${GDB_BIN} && GDB_BIN=`type -p gdb`
> +test -z "${GDB_BIN}" && GDB_BIN=`type -p gdb`
>  if [ -z "${GDB_BIN}" ]; then
>  	echo "ERROR: ${BASENAME} needs an installed gdb. "
>  	exit 1

When touching this, would it be possible that you eliminate
the use of -z? This showed to be not fully portable. That's
the reason why the test for a zero-length string in
configure.in is always written as [ x"$STRING" = x ] which
is more portable.

Thanks,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20061006/3d5c7210/attachment.bin


More information about the samba-technical mailing list