defining the new idmap subsystem
idra at samba.org
Tue Oct 3 03:16:38 GMT 2006
On Mon, 2006-10-02 at 20:08 -0700, Jeremy Allison wrote:
> On Mon, Oct 02, 2006 at 11:00:17PM -0400, simo wrote:
> > The problem is that this will duplicate all query calls, it's doable,
> > but I wonder if it is really worth it.
> Yes - it's not only worth it, it's essential.
> > So you would like to see something like splitting
> > idmap_uid_to_sid() into idmap_uid_to_sid_query() and
> > idmap_uid_to_sid_allocate() ?
> Yes. We need to know *explicitly* when an allocate happens.
Well that's explicitly done with the flag FLAG_ALLOCATE :-)
Would it be acceptable to have it as a bool option instead of a flag?
eg: NTSTATUS idmap_uid_to_sid(DOM_SID *sid, uid_t uid, BOOL allocate);
> > I think the code will be much uglier but if most want that, so be it.
> > But I'd like some more people complaining about that, before changing.
> I would vote -1 on you putting it in as-is - I think this
> is one case where I'm going to pull rank on you in design,
> sorry. I will not accept a flag-based replacement for this.
So you are ok also on duplicating all the winbindd calls too I guess.
Samba Team GPL Compliance Officer
email: idra at samba.org
More information about the samba-technical