Q about pidl client code in Samba 3

[Jelmer Vernooij]

Hi Jerry,

On Wed, 2006-09-27 at 17:32 -0500, Gerald (Jerry) Carter wrote:
> Gerald (Jerry) Carter wrote:
> > Jelmer,
> > 
> > I'm looking at the return code in rpccli_winreg_EnumKey():
> > 
> > 	/* Return variables */
> > 	*name = *r.out.name;
> > 	*keyclass = *r.out.keyclass;
> > 	*last_changed_time = *r.out.last_changed_time;
> > 
> > keyclass and last_changed_time are unique pointers so
> > it seems that they should be able to be NULL in the input.
> > If so, then the assignments need to be surrounded by
> > pointer checks.  Does this make sense?
> > 
> > I'm trying to put together a patch to pidl now 
> > for testing.
> 
> Assuming I'm correct with the above, how about
> the attached patch.
Looks good to me!

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20061002/f5e37d85/attachment.bin