Coverity errors in libndr/

Jelmer Vernooij jelmer at
Fri Nov 3 19:58:37 GMT 2006

Hi Volker,

On Tue, Oct 24, 2006 at 10:43:24PM +0200, Volker Lendecke wrote:
> Coverity has discovered a class of flaws in the generated
> NDR marshalling code.

> If you look at gen_ndr/ndr_echo.c:1166 we dereference
> r->in.foo1 but in line 1174 we check if that's NULL. So
> either the check in 1174 is unnecessary or should come
> before 1166. Foo1 in this case is a ref pointer, but a
> broken user of this API should not segfault I think, so I
> would tend to move the check to line 1166.

> But this goes a bit beyond my pidl knowledge.

> Comments?
I've just fixed this by simply removing the check completely. This
code would've only been triggered in case of invalid API usage and in
that case would've silently returned without any errors.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :

More information about the samba-technical mailing list