removing connection_struct argument from Samba3 VFS

Jeremy Allison jra at
Tue May 30 19:36:02 GMT 2006

On Tue, May 30, 2006 at 12:23:23PM -0700, Jeremy Allison wrote:
> I suggest you take a look at the differences between vfs_init_default()
> and vfs_init_custom() - specifically what (doesn't) happen to the
> vfs_handles pointer in the connection struct :-) :-).
> Yeah - you probably found a mis-design (ie. it never gets initialized
> in the default case) but the code you committed could never have worked :-) :-).

Ok - the VFS is horribly complex and overdesigned - and I do
appreciate you simplifying it. But I wish you'd tested it
better :-) :-).


More information about the samba-technical mailing list