removing connection_struct argument from Samba3 VFS

James Peach jpeach at
Mon May 29 23:00:29 GMT 2006

On Mon, 2006-05-29 at 16:26 +0200, Stefan (metze) Metzmacher wrote:
> Hash: SHA1
> Jeremy Allison schrieb:
> > On Mon, May 29, 2006 at 12:48:41PM +1000, James Peach wrote:
> >> Does anyone forsee any problems with this?
> > 
> > I'm ok with it but for HEAD, not 3.0 until we've
> > released 3.0.23. It's too late to change at the RC
> > stage. Remember to increment the VFS interface
> > revision number.
> The only thing I worry about is that external VFS modules need a lot of
> ifdef's in there code if they want to compile against different samba
> versions...

Modules that compile against multiple versions already need to do this,
though. Module compatibility has always been a bit of a nightmare, and
the VFS versioning only addresses part of that anyway.

James Peach | jpeach at

More information about the samba-technical mailing list