removing connection_struct argument from Samba3 VFS
jpeach at samba.org
Mon May 29 06:11:20 GMT 2006
On Sun, 2006-05-28 at 20:56 -0700, Jeremy Allison wrote:
> On Mon, May 29, 2006 at 12:48:41PM +1000, James Peach wrote:
> > Hi all,
> > In the current VFS, there are 3 ways to get at the connection_struct for
> > the current connection:
> > through the VFS handle struct argument
> > through the files_struct argument
> > through it being explicitly passed as an argument
> > I have a patch to remove the explicit passing of connection_struct
> > argument. Modules would use handle->conn (preferentially), though
> > existing uses of fsp->conn would be unchanged. you would no longer need
> > to pass the conn argument through the SMB_VFS_NEXT* macros.
> > Does anyone forsee any problems with this?
> I'm ok with it but for HEAD, not 3.0 until we've
> released 3.0.23. It's too late to change at the RC
> stage. Remember to increment the VFS interface
> revision number.
Yup, now version 17.
> If you commit to head we'll move back after 3.0.23
'k, r15929 (HEAD only)
James Peach | jpeach at samba.org
More information about the samba-technical