svn commit: samba r15904 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

[Jeremy Allison]

On Fri, May 26, 2006 at 12:28:55PM +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2006-05-26 12:28:55 +0000 (Fri, 26 May 2006)
> New Revision: 15904
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15904
> 
> Log:
> This does two things:
> 
> Fix more potential segfaults when something on our way to a DC connection
> fails.
> 
> We can not continue if dcip_to_name() fails. With
> 
> 192.168.234.100 nt4pdc
> 192.168.234.100 windows#1c
> 192.168.234.100 windows#1b
> 
> in the lmhosts file when nt4pdc is rebooted, we do find the DC's IP address,
> we can connect to TCP 139 while it is booting but anything else fails. So we
> fall back to put the IP address into domain->dcname. When the DC is fully up
> later on we try to do the auth2 against \\192.168.234.100 which gives
> INVALID_COMPUTER_NAME. And we never get out of this loop again.
> 
> Fix this.

I took a look over it - looks good ! How on earth
did you find this (what made you test this error
condition) ? Did you get an interesting backtrace
from someone or was this pure deduction ?

I'm very impressed !

Jeremy.