'msdfs root = yes' for [homes] ?

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker,

> Just found an unfortunate consequence of the default change
> to 'msdfs root = yes'. If you connect to [homes] under that
> name it is does not work anymore. You can easily reproduce
> it with current production code if you set msdfs root = yes
> in [homes] and try to access it via that name.
> 
> I traced it down to msdfs.c:422. For [homes] if you access
> it under that name 
> 
> strequal(dp.servicename, lp_servicename(SNUM(conn)))
> 
> is just not true. dp.servicename contains "homes", but
> lp_servicename contains the current username. So the dfs
> redirect stuff fails here.
> 
> With the attached patch it works again for me, but I'm not
> 100% certain that this is the correct thing to do, as I
> don't fully understand msdfs.c.

The patch looks good to me.  I'm checking it in.



- -- cheers, jerry

$ cat ~/.signature
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEbc8XIR7qMdg1EfYRArBdAKDUFLtiVs4sVD9jY9lLXLhHxsrBNwCghVwk
zHK8WT5/ITzJXUxVhedGunk=
=rDTN
-----END PGP SIGNATURE-----