[PATCH] [SAMBA3] updating internal copy of popt

James Peach jpeach at samba.org
Wed May 17 00:20:22 GMT 2006


On Wed, 2006-05-17 at 01:22 +0200, Jelmer Vernooij wrote:
> On Wed, 2006-05-17 at 08:56 +1000, James Peach wrote:
> > On Tue, 2006-05-16 at 14:20 +0200, Jelmer Vernooij wrote:
> > > On Tue, 2006-05-16 at 13:08 +1000, James Peach wrote:
> > > 
> > > > The attached patch updates the Samba3 copy of popt to the latest version
> > > > from the RPM 4.2 source. I found that this fixes a very odd failure
> > > > which looked like some sort of gcc optimiser quirk.
> > > > 
> > > > Posting the patch before I commit just in case there are issues in
> > > > upgrading this that I'm not aware of.
> > > Should be fine to commit. 
> > >
> > > Where did this source come from, the popt tarball from the RedHat site
> > > or from the RPM sources? I haven't been able to find popt updates as
> > > separate tarballs for a while now.
> > >From the RPM sources. The popt RPM is built from the RPM specfile so I'm
> > guessing that popt is no longer distributed separately from RPM.
> > 
> > If there aren't any special issues to consider, I'll commit this update
> > in a few hours. Do you want me to update Samba4 as well?
> Please do.

Looks like you already did this in r5906. There are some discrepancies
between the version in Samba4 and the version I pulled from rpm-4.2 (see
attached diff). Did you make any local changes?

-- 
James Peach | jpeach at samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba4-popt-changes.diff
Type: text/x-patch
Size: 7315 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20060517/83660324/samba4-popt-changes.bin


More information about the samba-technical mailing list