BASE-TCONDEV test broken against Samba3??

[Jeremy Allison]

On Tue, May 16, 2006 at 10:50:57PM +0200, Volker Lendecke wrote:
> Hi!
> 
> No idea why, but I need to apply
> 
> --- smbd/reply.c        (Revision 15636)
> +++ smbd/reply.c        (Arbeitskopie)
> @@ -643,7 +643,7 @@
>                 password.data[passlen]=0;
>         }
> 
> -       p = smb_buf(inbuf) + passlen;
> +       p = smb_buf(inbuf) + passlen + 1;
>         p += srvstr_pull_buf(inbuf, path, p, sizeof(path), STR_TERMINATE);
> 
>         /*
> 
> to Samba3 to make BASE-TCONDEV succeed against it. This
> survives the basic test: w2k3 can still connect.
> 
> No idea how it can work without this test, maybe Jeremy, can
> you help me here?
> 
> Volker
> 
> P.S: Question: Is it expected that Samba4 does not connect
> to a security=share server?

I think that Samba4 is not correct here. I remember looking
at this. We accept what Windows sends - possibly we should
check if *(smb_buf(inbuf) + passlen) ==0 and increment by
one if so - but currently we are correct for Windows clients.

Don't apply this change please.

Jeremy.