Samba 3.0.23pre1 problem listing groups with ldapsam backend

[Jim McDonough]

>> I see in passdb/pdb_ldap.c the code setting up the search filter is 
>> at line 4305 in ldapsam_search_grouptype.  Shouldn't it
>> be (SambaSID=%s*) instead of (SambaSID=%s) since the domain sid is
>> passed in and we want to match all groups that start with that
>> SID?
>
>I haven't looked at the code you mention yet, but what you describe
>sounds right.  Mind sending me a patch ?
Here it is, courtesy of John...you know...rules and all....

--- passdb/pdb_ldap.c~  2006-05-03 15:25:40.000000000 -0500
+++ passdb/pdb_ldap.c   2006-05-03 16:41:01.000000000 -0500
@@ -4304,7 +4304,7 @@
        state->scope = LDAP_SCOPE_SUBTREE;
        state->filter = talloc_asprintf(search->mem_ctx,
 "(&(objectclass=sambaGroupMapping)"
- "(sambaGroupType=%d)(sambaSID=%s))",
+ "(sambaGroupType=%d)(sambaSID=%s*))",
                                        type, sid_string_static(sid));
        state->attrs = talloc_attrs(search->mem_ctx, "cn", "sambaSid",
                                    "displayName", "description",

----------------------------
Jim McDonough
IBM Linux Technology Center
Samba Team
6 Minuteman Drive
Scarborough, ME 04074
USA

jmcd at us dot ibm dot com 
jmcd at samba dot org

Phone: 1-877-228-1846
IBM tie-line: 349-5335