Remove functions from SAMBA_VERSION_STRING
jpeach at samba.org
Wed May 3 23:39:40 GMT 2006
On Wed, 2006-05-03 at 06:57 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Andrew Bartlett wrote:
> > I would like to remove the ability to use C functions, and
> > instead bring it back to a simple macro. This ensures that
> > we never allocate in the fault code (as a C function in
> > this location would probably have to allocate it's return value).
we have to allocate to print a stack trace
> > As version strings should never change at runtime, any more
> > complex expressions could be included in a script to generate
> > VERSION, if required.
> > SAMBA_VERSION_STRING could then return to being a constant string.
> > Any objections? Metze wants this in sync between Samba3 and Samba4
> I've never used it. If metze wants to remove it, them
> that's fine with me since it was his code to begin with IIRC.
> James, Lars? Have you guys ever used it for packaging?
My packaging build includes a patch that sets
SAMBA_VERSION_VENDOR_SUFFIX to a string literal. Having some way to flag
that smbd is a vendor version is necessary, but I don't mind what it is.
I don't need any function calls for this.
James Peach | jpeach at samba.org
More information about the samba-technical