Remove functions from SAMBA_VERSION_STRING

Andrew Bartlett abartlet at
Wed May 3 09:07:35 GMT 2006

On Wed, 2006-05-03 at 11:02 +0200, Andrew Bartlett wrote:
> In Samba3 and Samba4, SAMBA_VERSION_STRING is a macro, which should
> expand to the current version.  We have a complex VERSION file that
> should allow almost any combination of pre, rc and vendor strings to be
> included in it.
> Currently, this file allows the use of arbitary C functions.  I would
> like to 

(you get the idea...)

I would like to remove the ability to use C functions, and instead bring
it back to a simple macro.  This ensures that we never allocate in the
fault code (as a C function in this location would probably have to
allocate it's return value).  As version strings should never change at
runtime, any more complex expressions could be included in a script to
generate VERSION, if required.

SAMBA_VERSION_STRING could then return to being a constant string.

Any objections?  Metze wants this in sync between Samba3 and Samba4

Andrew Bartlett

Andrew Bartlett                      
Authentication Developer, Samba Team 
Student Network Administrator, Hawker College
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list