Proposed patches for samba4

Jelmer Vernooij jelmer at samba.org
Mon May 1 14:10:52 GMT 2006


On Mon, 2006-05-01 at 09:44 -0400, Green, Paul wrote:
> I've put samba4 into the build job on my VOS PA-RISC box to see how far
> I can get.  Not very far.  Jelmer just noticed the first problem, that
> one of the heimdal static archives had a name longer than 32 chars, and
> fixed it (many thanks!).
Sorry, I wasn't aware we were working at this in parallel.. 

> Here are a couple of other patches.  I think they should be safe for
> everyone, but I haven't applied them to the svn yet.    If someone would
> ok then, I'll do that.
I'm about to commit a patch that simply removes select.c, so we don't
have to pull in sys/select.h for all files. Sorry for the overlap.

> diff -urpN old/samba4/source/lib/replace/replace.c
> new/samba4/source/lib/replace/replace.c
> --- old/samba4/source/lib/replace/replace.c  Sun Apr 30 17:09:07 2006
> +++ new/samba4/source/lib/replace/replace.c  Mon May  1 07:11:53 2006
> @@ -200,6 +200,9 @@ Corrections by richard.kettlewell at kewill
>      errno = ENOSYS;
>      return -1;
>  #else /* HAVE_SETGROUPS */
> +
> +#include <grp.h>
> +
>      gid_t *grouplst = NULL;
>      int max_gr = groups_max();
>      int ret;
Looks good to me.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060501/1afd2808/attachment.bin


More information about the samba-technical mailing list