svn commit: samba r14085 - branches/SAMBA_3_0/source/utils trunk/source/utils

[Jeremy Allison]

On Thu, Mar 09, 2006 at 06:03:54PM +0000, jmcd at samba.org wrote:
> Author: jmcd
> Date: 2006-03-09 18:03:54 +0000 (Thu, 09 Mar 2006)
> New Revision: 14085
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14085
> 
> Log:
> Fix coverity bg #152, uninit'ed var.
> 
> Modified:
>    branches/SAMBA_3_0/source/utils/net_rpc_join.c
>    trunk/source/utils/net_rpc_join.c
> 
> 
> Changeset:
> Modified: branches/SAMBA_3_0/source/utils/net_rpc_join.c
> ===================================================================
> --- branches/SAMBA_3_0/source/utils/net_rpc_join.c	2006-03-09 18:01:48 UTC (rev 14084)
> +++ branches/SAMBA_3_0/source/utils/net_rpc_join.c	2006-03-09 18:03:54 UTC (rev 14085)
> @@ -137,7 +137,7 @@
>  
>  	NTSTATUS result;
>  	int retval = 1;
> -	char *domain;
> +	char *domain = NULL;
>  	uint32 num_rids, *name_types, *user_rids;
>  	uint32 flags = 0x3e8;
>  	char *acct_name;

Jim, I think this one needs more than this. We also need
to check domain != NULL before use at line 406 - probably
bail out earlier....

Jeremy.