svn commit: samba r13989 - in branches/SAMBA_3_0/source/rpc_parse: .

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

jra at samba.org wrote:
> Author: jra
> Date: 2006-03-07 20:52:43 +0000 (Tue, 07 Mar 2006)
> New Revision: 13989
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13989
> 
> Log:
> Fix for Coverity bug #45 and associated spoolss RPC_BUFFER
> problems. Ensure that if the parse succeeds on UNMARSHALL
> we have a valid (although possibly empty) RPC_BUFFER returned.
> Jeremy.

Jeremy, I think this is the wrong approach.  And yet just one more
reason to move us to IDL.  The purpose of a RPC_BUFFER* in
include/rpc_spoolss.h is that the pointer _should_ be NULL
if the client did not send one.  Your patch changes the semantics.
The srv_spoolss_nt.c implementation code should check for
NULL pointers, not empty buffers.  This patch lies to the caller.





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEDv5hIR7qMdg1EfYRAsNaAJ9/5I70AwQxdu5AQDqi2Mx9ibeiTQCfTGQj
9RC4aeAlhnNydgcl4JDuM20=
=dMuG
-----END PGP SIGNATURE-----