svn commit: samba r13989 - in
Gerald (Jerry) Carter
jerry at samba.org
Wed Mar 8 15:55:13 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
jra at samba.org wrote:
> Author: jra
> Date: 2006-03-07 20:52:43 +0000 (Tue, 07 Mar 2006)
> New Revision: 13989
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13989
> Fix for Coverity bug #45 and associated spoolss RPC_BUFFER
> problems. Ensure that if the parse succeeds on UNMARSHALL
> we have a valid (although possibly empty) RPC_BUFFER returned.
Jeremy, I think this is the wrong approach. And yet just one more
reason to move us to IDL. The purpose of a RPC_BUFFER* in
include/rpc_spoolss.h is that the pointer _should_ be NULL
if the client did not send one. Your patch changes the semantics.
The srv_spoolss_nt.c implementation code should check for
NULL pointers, not empty buffers. This patch lies to the caller.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical