timy error in tracerse.c ?

[Jeremy Allison]

On Wed, Mar 01, 2006 at 10:43:00AM -0500, simo wrote:
> In lib/tdb/common/traverse.c, line 178 we have the following code:
> 
>                 if (fn && fn(tdb, key, dbuf, private)) {
>                         /* They want us to terminate traversal */
>                         ret = count;
>                         if (tdb_unlock_record(tdb, tl->off) != 0) {
>                                 TDB_LOG((tdb, 0, "tdb_traverse:
> unlock_record failed!\n"));;
>                                 ret = -1;
>                         }
>                         tdb->travlocks.next = tl->next;
>                         SAFE_FREE(key.dptr);
>                         return count;
>                 }
> 
> 
> it seem to me that
> 	return count;
> is wrong and that should be
> 	return ret;
> 
> Should I commit a fix? Or is there something I'm not understanding ?

That looks correct to me.

Jeremy.