svn commit: samba r16397 - in branches/SAMBA_3_0/source/smbd: .

[Gerald (Jerry) Carter]

James Peach wrote:

>>> You lost the AS_GUEST flag clearing on purpose?
>>
>> Yes. If you look at the SMB definition table (function mapper)
>> you will see that if AS_USER is set then AS_GUEST is *never*
>> set.
> 
> 
> Could you add an SMB_ASSERT to that effect?
> 
> if (flags) {
> 	SMB_ASSERT((flags & AS_USER) ? !(flags & AS_GUEST)
>                                      : (flags & AS_GUEST) )
> }
> 
>> This makes that clause impossible to be executed.
> 
> Agreed (provided no-one ever adds AS_USER | AS_GUEST to smb_messages).

I don't think the assert is necessary since the flags are
defined in a static table.  We're not dealing with input parameters
here.




cheers, jerry