svn commit: samba r16410 - in
branches/SAMBA_4_0/source/smb_server: . smb2
abartlet at samba.org
Wed Jun 21 03:16:04 GMT 2006
On Tue, 2006-06-20 at 11:59 +0200, Jelmer Vernooij wrote:
> On Tue, 2006-06-20 at 09:57 +0000, metze at samba.org wrote:
> > Author: metze
> > Date: 2006-06-20 09:57:00 +0000 (Tue, 20 Jun 2006)
> > New Revision: 16410
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16410
> > Log:
> > remove some warnings of talloc_steal() usage without target
> > I only commit this as this is used in a global macro
> > tridge: we should try to get rid of this warning without using
> > (void)talloc_steal(ctx, ptr);
> > everywhere!!!
> I think we should really ask whether that return value is ever going to
> be different from ptr. If it is, we should use the return value
> everywhere; if it isn't we should probably drop the return value imho.
One of the big issues here is that talloc_steal used to return a void*,
so code was changed not to use the return value (so we would be type
safe). Now that it returns a typeof() based pointer (on recent GCC), it
is safer, but the code has already been written differently.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Student Network Administrator, Hawker College http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060621/1c00b6ce/attachment.bin
More information about the samba-technical