svn commit: samba r16397 - in branches/SAMBA_3_0/source/smbd: .

Gerald (Jerry) Carter jerry at samba.org
Tue Jun 20 16:40:25 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerald (Jerry) Carter wrote:

>>>>> Author: jra
>>>>> Date: 2006-06-20 02:38:28 +0000 (Tue, 20 Jun 2006)
>>>>> New Revision: 16397
...
> James is right.  The logic is different in two places,
> Before if change_to_user() failed bu the AS_GUEST flag was
> set the code would fall on through.  Now it always fails.
> Can you help me understand under what conditions the old
> code would have been executed? I have a feeling it may
> be for security = share.

So the AS_USER and AS_GUEST never appear in
the smb_message_struct dispatch table together
so that code was unneeded.  Otherwise
everything looks correct. I'll update the release
tree today.





cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEmCT5IR7qMdg1EfYRAkoeAKCh51/HnGLZKHgKju/AYmqs9J9tcwCgiCPP
xEO8iuAOK36LXiJjddokzXk=
=u4be
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list