svn commit: samba r16397 - in branches/SAMBA_3_0/source/smbd: .

[Jeremy Allison]

On Tue, Jun 20, 2006 at 05:21:24PM +1000, James Peach wrote:
> On Tue, 2006-06-20 at 02:38 +0000, jra at samba.org wrote:
> > Author: jra
> > Date: 2006-06-20 02:38:28 +0000 (Tue, 20 Jun 2006)
> > New Revision: 16397
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16397
> > 
> > Log:
> > Fix Klocwork #11767 and drasticly simplify the
> > logic in smbd/process.c. All interested (Volker,
> > Jerry, James etc). PLEASE REVIEW THIS CHANGE.
> > The logic should be identical but *much* easier
> > to follow and change (and shouldn't confuse Klockwork :-).
> 
> You lost the AS_GUEST flag clearing on purpose?

Yes. If you look at the SMB definition table (function mapper)
you will see that if AS_USER is set then AS_GUEST is *never*
set. This makes that clause impossible to be executed. It
probably was needed at an earlier point in the table but it's
dead code now. Please check and make sure, but that was my
analysis.

Jeremy.