[PATCH] [Samba4] Map special DNs to CN=Special container

simo idra at samba.org
Thu Jun 15 13:40:05 GMT 2006


On Thu, 2006-06-15 at 15:26 +0200, Martin Kühl wrote:

> ac->search_req isn't allocated yet when I call un_remap_special_dn();
> I did that so I could bail out from easy to spot errors before
> allocating large chunks, like the async handle and context.
> Hm, now that I said that, it sounds a lot like premature optimization.

talloc is used exactly for the purpose of tracking memory and freeing it
later on without leaking.
If you get an error and you alloc on the module context than you leak
memory if you forget to free it.
If you alloc on search_req it will be freed once the caller get an error
and frees the original ldb_request.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-technical mailing list