svn commit: samba r16241 - in branches/SAMBA_3_0/source: auth pam_smbpass passdb rpc_server smbd utils

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

jra at samba.org wrote:
> Author: jra
> Date: 2006-06-15 01:54:09 +0000 (Thu, 15 Jun 2006)
> New Revision: 16241
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16241
> 
> Log:
> Fix Klocwork #106 and others like it.
> Make 2 important changes. pdb_get_methods()
> returning NULL is a *fatal* error. Don't try
> and cope with it just call smb_panic. This
> removes a *lot* of pointless "if (!pdb)" handling
> code. Secondly, ensure that if samu_init()
> fails we *always* back out of a function. That
> way we are never in a situation where the pdb_XXX()
> functions need to start with a "if (sampass)"
> test - this was just bad design, not defensive
> programming.

Dude, why do you *always* have to include reformatting
with your patches?


jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEkUPmIR7qMdg1EfYRAki5AKDeWZMfHgIUnGWKhPcOTgEp7lX1XgCeOipa
j67Kneo5Q4K22TYivRUtPts=
=zaXn
-----END PGP SIGNATURE-----