SOC Automated Windows Testing Project

[tridge at samba.org]

Brad,

I've been having a look at your current expect/vbs scripts, and I
think you've made great progress! I've got them working here, and have
a few comments.

The win_setup.wsf script is great, and it worked first time for
me. Using the telnet service like this is ideal for easy
deployment. 

I needed to make a couple of trivial mods to the test run script
first:

 - added SMBTORTURE_WORKGROUP var in wintest_run.sh as I haven't made
   my existing vmware session use 'SMBTEST' 

 - added a SMBTORTURE_PATH variable in wintest_run.sh as I am not
   using /usr/local/bin

Maybe we should have a win_test.conf file containing just the local
variable settings and use ". win_test.conf" near the start of the
script?

I also hit a bit of a problem with DNS lookups. My w2k3 server did a
reverse lookup on the IP of my test box when the telnet connection
started up. That reverse lookup failed, and the telnet connection
timed out. I worked around it by adding "-timeout 60" to the "expect
login:" line in common.exp, but perhaps we could make things more
robust by adding a hosts entry on the windows box for the IP/hostname
of the client (ideally we would remove it at the end too).

After I upped the timeout, the test ran (yipee!) but RAW-QFILEINFO
failed, and I noticed that the script skips the cleanup phase when the
test fails, so the smbtorture_share share wasn't deleted. That should
be easy to fix. I'm not worried about the fact that RAW-QFILEINFO
failed (thats nothing to do with your project), just the error
handling.

I guess the next major steps are:

 - the vmware snapshot/resume scripts
 - modifying the scripts in samba4/source/script/tests to optionally
   call this stuff if enabled

Then we can setup a box in the build farm to start running this on
each commit.

I also wonder how we should get your other vbs scripts onto the
windows box during tests? The two obvious methods are:

 - make them available via a Samba share, and to net use that share
   then copy the files

 - add a copy_file() function in common.exp which does a 
   "copy con xxx.vbs" and sends the file down the link, followed by a ^Z. 

The think the second option might be better, as it has "less moving
parts" so hopefully it will be less fragile once its working. It won't
work for binary files, but I don't think we'll need any of those.

What do you think?

Cheers, Tridge