talloc destructor in brlock.c?

Jeremy Allison jra at samba.org
Tue Jun 13 18:03:54 GMT 2006

On Tue, Jun 13, 2006 at 04:17:19PM +0200, Volker Lendecke wrote:
> Does that really hurt that much? I'm asking because we're
> trying to advance the cluster stuff, and having a nice
> straight API to the tdb that essentially matches the API to
> locking.tdb would make the work a bit easier.
> What would persuade you to get it in again? How much loss
> in what test would you accept? :-)

At the time I removed it I was on a cycle counting binge..
It did help, but it wasn't really significant - the O_SYNC
was the real winner :-). I'm happy for you to put it back
if you like, so long as you make sure the comment is explicit
about the destructor releasing the resource.


More information about the samba-technical mailing list