svn commit: samba r16149 - in branches/SAMBA_4_0/source/torture: . raw

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

vlendec at samba.org schrieb:
> Author: vlendec
> Date: 2006-06-12 10:18:15 +0000 (Mon, 12 Jun 2006)
> New Revision: 16149
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16149

> +static void init_unixinfo_nochange(union smb_setfileinfo *info)
> +{
> +	ZERO_STRUCTP(info);
> +	info->unix_basic.level = RAW_SFILEINFO_UNIX_BASIC;
> +	info->unix_basic.in.mode = SMB_MODE_NO_CHANGE;
> +
> +	info->unix_basic.in.end_of_file = SMB_SIZE_NO_CHANGE_HI;
> +	info->unix_basic.in.end_of_file <<= 32;
> +	info->unix_basic.in.end_of_file |= SMB_SIZE_NO_CHANGE_LO;
> +	
> +	info->unix_basic.in.num_bytes = SMB_SIZE_NO_CHANGE_HI;
> +	info->unix_basic.in.num_bytes <<= 32;
> +	info->unix_basic.in.num_bytes |= SMB_SIZE_NO_CHANGE_LO;
> +	
> +	info->unix_basic.in.status_change_time = SMB_TIME_NO_CHANGE_HI;
> +	info->unix_basic.in.status_change_time <<= 32;
> +	info->unix_basic.in.status_change_time = SMB_TIME_NO_CHANGE_LO;
> +
> +	info->unix_basic.in.access_time = SMB_TIME_NO_CHANGE_HI;
> +	info->unix_basic.in.access_time <<= 32;
> +	info->unix_basic.in.access_time = SMB_TIME_NO_CHANGE_LO;
> +
> +	info->unix_basic.in.change_time = SMB_TIME_NO_CHANGE_HI;
> +	info->unix_basic.in.change_time <<= 32;
> +	info->unix_basic.in.change_time = SMB_TIME_NO_CHANGE_LO;

Hi Volker,

you're missing some '|=' here...

wouldn't it be nicer to have SMB_*_NO_CHANGE; instead of 2 seperate
_HI/_LO values?

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEjUvdm70gjA5TCD8RAh5wAKCaa5hLZAgYCcF4hPSSLw69kTtphgCeKnmo
pmcKni1AWjgk4Lqp9KNu4Ec=
=6F8N
-----END PGP SIGNATURE-----