[PATCH][SAMBA3] allow VFS modules to extend files_struct
jpeach at samba.org
Thu Jun 8 02:13:46 GMT 2006
On Tue, 2006-06-06 at 20:39 -0700, Jeremy Allison wrote:
> On Wed, Jun 07, 2006 at 12:06:53PM +1000, James Peach wrote:
> > aren't the existing modules better examples?
> No - the implementation hides the interface. The
> example modules just show interface with no implementation.
> Much easier to copy and modify.
> > > ie. If you change the VFS interface and don't update
> > > the examples I'll *kill* you :-) :-).
I've updated skel_transparent, but skel_opaque uses the vfswrap
functions to provide the opaque operations. These are now static
functions in vfs_default, so there's (at least) 4 choices:
1. return EINVAL for everything
2. make the vfswrap symbols public again
3. change skel_opaque to do exactly what vfs_default does
4. remove skel_opaque on the basis that vfs_default is a
I'm leaning towards 2 or 4, do you have a preference?
James Peach | jpeach at samba.org
More information about the samba-technical