[PATCH][SAMBA3] allow VFS modules to extend files_struct

Jiri Klouda jk at zg.cz
Mon Jun 5 20:58:45 GMT 2006


Hi,
wouldn't it be better if each module just kept this data in its own
data segment in any form they wish? It seems like this is fracturing
the allocated data of each module and making it harder to cleanup.

Also, instead of allocating a specific size block, wouldn't it be 
better to just have one void pointer and let the module manage it 
in the way they see fit? Like to put it under a different common
talloc parent?

Regards,
-Jiri
 
On Mon 05-06-06 17:34:22, James Peach wrote:
> Hi all,
> 
> The attached patch adds an API to allow VFS modules to attach private
> per-module data to a files_struct. This patch is against SAMBA_3_0, but
> if it passes review, I'll commit it to trunk until 3.0.23 goes out.
> 
> Jeremy, I was able to get rid of specifying the payload completely, so I
> hope this makes us both happy. If not, I can revert to supplying a void
> * payload ...
> 
> -- 
> James Peach | jpeach at samba.org

-- 
Jiri Klouda <jk at zg.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20060605/8f0ae9ea/attachment.bin


More information about the samba-technical mailing list