[PATCH][SAMBA3] allow VFS modules to extend files_struct

Jeremy Allison jra at samba.org
Mon Jun 5 13:05:24 GMT 2006

On Mon, Jun 05, 2006 at 05:34:22PM +1000, James Peach wrote:
> Hi all,
> The attached patch adds an API to allow VFS modules to attach private
> per-module data to a files_struct. This patch is against SAMBA_3_0, but
> if it passes review, I'll commit it to trunk until 3.0.23 goes out.
> Jeremy, I was able to get rid of specifying the payload completely, so I
> hope this makes us both happy. If not, I can revert to supplying a void
> * payload ...

I still prefer a void * payload. There's no guarentee a compiler won't
add padding to the end of the vfs_fsp_data struct... (yeah I know that'll
be aligned). I think the code as written will work, but it's too "clever"
for it's own good :-). That way lies tears in the end :-).

> +   Copyright (C) 2006 Silicon Graphics, Inc. All rights reserved.
> +	James Peach, <jpeach at sgi.com>
> +

Woop ! Woop ! Corporate (C) ahead... that needs changing to just
yours :-).


More information about the samba-technical mailing list