[SAMBA4] New objectclass module
abartlet at samba.org
Fri Jun 2 21:40:29 GMT 2006
On Fri, 2006-06-02 at 16:20 -0400, simo wrote:
> On Sat, 2006-06-03 at 01:04 +1000, Andrew Bartlett wrote:
> > As per my mail about the objectClass sorting being incorrect in current
> > Samba4, I decided to revive the sorting module. I did this mostly to
> > try and gain some skill in the new, more complex, async ldb.
> > I've tested this with 'make test', which runs a provision and checks the
> > objectclass list on add. (I need to extend the patched ldap.js I sent
> > yesterday to do a modify).
> > Any comments?
> - if the object has not objectclasses on add then you can probably just
> return an error, this will be done by the schema module later, but it
> make no sense to allow to create objects without objectclasses in
> sam.ldb (in an add operation you can't delete btw)
Yeah, good point.
> - on add you do not need to do the operation, then search, then modify.
> The objectclass module must clearly be the last one that manipulates
> objectclasses, so on add you can just sort the classes and then do the
> operation as you already have all the classes from the original
I was doing this to make the codepaths more common, and therefore more
tested. This is the same reason I did this in the password_hash module.
> - returning "Invalid search filter" in objectclass_search_self() may
> confuse the user as this is a modify/add operation (you should
> probably mention an internal error has occurred
> Aside these minor issues it is a well done module.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Student Network Administrator, Hawker College http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060603/e7a1fd46/attachment.bin
More information about the samba-technical