Samba 3.0.23a: lib/smbldap.c unsigned compare bug

[Jim Brown]

Jeremy

This bug is still present is 3.0.23a (released July 21).

Jim

*** smbldap.c.orig      Fri Jun  9 19:30:31 2006
--- smbldap.c   Mon Jul 24 15:52:48 2006
***************
*** 325,331 ****
                return NULL;
        }

!       if (pull_utf8_talloc(mem_ctx, &result, values[0]) < 0) {
                DEBUG(10, ("pull_utf8_talloc failed\n"));
                ldap_value_free(values);
                return NULL;
--- 325,331 ----
                return NULL;
        }

!       if (pull_utf8_talloc(mem_ctx, &result, values[0]) == (size_t)-1) {
                DEBUG(10, ("pull_utf8_talloc failed\n"));
                ldap_value_free(values);
                return NULL;

> On Tue, Jul 11, 2006 at 01:48:58PM -0400, Jim Brown wrote:
> > There is an unsigned compare error in Samba 3.0.23 routine
> > lib/smbldap.c at line 328.
> 
> Already fixed in svn thanks - just missed the 3.0.23
> cutover point I think.