get_queue_status ?

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker Lendecke wrote:
> Hi!
> 
> Trivial question about style... The two existing callers of
> get_queue_status both have the second argument != NULL,
> pointing to a stack variable. Can we remove the checks in
> get_queue_status, or is there any reason behind this?

I think this is historical.  IIRC we used to call get_queue_status()
with a NULL status argument to either fetch the number of jobs
(possibly before the tdb per queue rewrite) or just ensure the queue
was up to date.  If the current code always calls get_queue_status()
with a non-null argument, then the assert() is probably ok.






jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEw7zaIR7qMdg1EfYRAg8mAKCvbL27Rz5O0LkT/kMGcXm4TooWIQCbBfhk
Emk6zGtyLLOJWJVQz3cq2T8=
=Adas
-----END PGP SIGNATURE-----