[PATCH][SAMBA_4_0] modular services configuration
idra at samba.org
Fri Jul 21 21:12:15 GMT 2006
On Fri, 2006-07-21 at 13:19 +0200, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> simo schrieb:
> > On Wed, 2006-07-19 at 16:22 +0200, Stefan (metze) Metzmacher wrote:
> >>> Will try to address the problems you mentioned soon, are you ok if I
> >>> commit it to the tree when these problems are solved? Or do you prefer
> >>> to review the code again as a patch?
> >> as patch please:-)
> > And here it is.
> I almost happy:-)
> just a few minor things:
> - - can you change the error handling
> from if ((foo = function()) == NULL)
> of if (!NT_STATUS_IS_OK(function())
> foo = function();
> if (!foo) ...
> ntstatus = function();
> if (!NT_STATUS_IS_OK(ntstatus))
Uhmm this is the new convention for code in samba3, but I am not a
particular fan of this method.
> I think this is much more readable and
> in gdb you can do a p ntstatus, and also this is
> how the rest of samba4 looks like
> - - make more functions static!
Samba Team GPL Compliance Officer
email: idra at samba.org
More information about the samba-technical