ldap uri appendage in ad idmap module?

Gerald (Jerry) Carter jerry at samba.org
Thu Jul 13 02:52:15 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Guenther,

Please take a look at this patch and tell me if you think
the uri is needed.  I removed LDAP uri support from 
the ad module a few months ago during the DNS SRV cleanup.




cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQFEtbVmIR7qMdg1EfYRAuMLAJ9Narsqgp3uLzPUbrfJgeIpbrmoCgCeJSvT
LDZGJFjOUS9SL8UxBr0Y7as=
=qphL
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: source/sam/idmap_ad.c
===================================================================
--- source/sam/idmap_ad.c	(revision 17003)
+++ source/sam/idmap_ad.c	(working copy)
@@ -35,7 +35,6 @@
 NTSTATUS init_module(void);
 
 static ADS_STRUCT *ad_idmap_ads = NULL;
-static char *ad_idmap_uri = NULL;
 
 static char *attr_uidnumber = NULL;
 static char *attr_gidnumber = NULL;
@@ -141,11 +140,6 @@
 
 static NTSTATUS ad_idmap_init(const char *uri)
 {
-	ad_idmap_uri = SMB_STRDUP(uri);
-	if (ad_idmap_uri == NULL) {
-		return NT_STATUS_NO_MEMORY;
-	}
-
 	return NT_STATUS_OK;
 }
 


More information about the samba-technical mailing list