Samba 3.0.23: lib/smbldap.c unsigned compare bug

Jim Brown jim at rrsl.rsmas.miami.edu
Tue Jul 11 17:48:58 GMT 2006


There is an unsigned compare error in Samba 3.0.23 routine
lib/smbldap.c at line 328.

--- lib/smbldap.c.orig  Fri Jun  9 19:30:31 2006
+++ lib/smbldap.c       Tue Jul 11 17:41:49 2006
@@ -325,7 +325,7 @@
                return NULL;
        }

-       if (pull_utf8_talloc(mem_ctx, &result, values[0]) < 0) {
+       if (pull_utf8_talloc(mem_ctx, &result, values[0]) == (size_t)-1) {
                DEBUG(10, ("pull_utf8_talloc failed\n"));
                ldap_value_free(values);
                return NULL;

Jim


More information about the samba-technical mailing list