svn commit: samba r16746 - in trunk/source/rpc_parse: .

Gerald (Jerry) Carter jerry at samba.org
Sat Jul 1 17:14:18 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Allison wrote:
> On Sat, Jul 01, 2006 at 04:56:15PM +0000, vlendec at samba.org wrote:
>> Author: vlendec
>> Date: 2006-07-01 16:56:13 +0000 (Sat, 01 Jul 2006)
>> New Revision: 16746
>>
>> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16746
>>
>> Log:
>> Fix a warning from a 64-bit build:
>>
>> rpc_parse/parse_srv.c: In function `srv_io_file_info3':
>> rpc_parse/parse_srv.c:2407: warning: cast from pointer to integer of different
>> size
>> rpc_parse/parse_srv.c:2416: warning: cast from pointer to integer of different size
>>
>> I think this actually fixes a (VERY unlikely) bug. Imagine fl3->path having an
>> address where only the high 32 bits are != 0....
>>
>> Jerry, please check this.
> 
> This is hilarious - I was on the phone with
> Jerry and got a svn conflict message checking
> in *EXACTLY THE SAME FIX* ! Identical :-).

Yup.  It's the correct fix.





jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEpq1pIR7qMdg1EfYRAi4GAJ9KyLwzWvt+wyBMrTAadqNiUeeFmgCeLAuW
gDRQK0ksXIrJSyWHVVefYUg=
=z6Ke
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list