ldb_search interface considered harmful

[simo]

On Tue, 2006-01-31 at 22:21 +1100, Andrew Bartlett wrote:
> On Tue, 2006-01-31 at 16:02 +1100, Andrew Bartlett wrote:
> > I've recently been working on the Samba4 code, and the output of
> > --leak-report-full in particular.
> > 
> > The contents of this (for an inactive connection) should be quite small,
> > but I initially found a large number of ldb_message structures being
> > kept around.  
> 
> While I still think the interface needs work, I actually found that a
> bug in the index'ed path caused the ldb_message (and not the ldb_result)
> to be attached to the ldb.  This cleaned up the remaining cases I found.

This need to be fixed!
As said before by freeing the result you must be sure everything get
freed.

Simo.

-- 
Simo Sorce
Samba Team
email: idra at samba.org
http://samba.org/~idra