[PATCH] Named pipe abstraction

Stefan (metze) Metzmacher metze at samba.org
Fri Jan 27 07:45:32 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij schrieb:
> The attached patch adds an abstraction layer for the named pipe layer
> in Samba 4. This allows (among other things), a clearer distinction
> between the SMB, RPC and RAP protocol implementations.
> 
> It still needs more testing against windows, but it already 
> passes the torture tests. A new torture test for a simple \PIPE\ECHO
> pipe is also included.

For me it looks good!

> Index: build/smb_build/smb_build_h.pm
> ===================================================================
> --- build/smb_build/smb_build_h.pm	(revision 13175)
> +++ build/smb_build/smb_build_h.pm	(working copy)
> @@ -28,7 +28,10 @@
>  
>  	foreach my $key (values %{$depend}) {
>  		my $DEFINE = ();
> -		next if ($key->{TYPE} ne "LIBRARY" and $key->{TYPE} ne "SUBSYSTEM");
> +		next if ($key->{TYPE} ne "LIBRARY" and 
> +				 $key->{TYPE} ne "SUBSYSTEM" and 
> +			 	 $key->{TYPE} ne "BINARY" and 
> +			 	 $key->{TYPE} ne "MODULE");
>  		next unless defined($key->{INIT_FUNCTIONS});
>  		
>  		$DEFINE->{COMMENT} = "$key->{TYPE} $key->{NAME} INIT";

should this be in this patch?

- --
metze

Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFD2c+am70gjA5TCD8RAm+jAKCcpN9rzeDav1/IfQaAS3V1FTmc3gCfXTcH
KQVhbJuuC76jiItjBZay5Mc=
=gDRl
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list