[SAMBA4][PATCH] dd client for samba 4

[James Peach]

On Tue, 17 Jan 2006 01:39 pm, Andrew Bartlett wrote:
> On Tue, 2006-01-17 at 13:16 +1100, James Peach wrote:
> > Hi all,
> >
> > The attached patch implements a dd clone that can perform IO to/from CIFS
> > servers. Samba 4 folks, could you please review this before I check it
> > in?
>
> How critical is standard DD syntax?  It seems a real pity to avoid the
> standard popt we provide for the rest of Samba4.

Without dd syntax it wouldn't be a dd clone, which would defeat (some of)
the purpose from my point of view.

> This would avoid your credentials problem. (Supporting the SMB url would
> be nice, but it sucks for conveying username, domain and password
> info).
>
> Also, it ensures you correctly setup debug, loadparm and many other
> systems.  We hook our 'must be done by every samba program' code into
> popt, because it's called at the 'right time'.

Is there something I missed?

> On coding style, it just doesn't seem to match that in which the rest of
> Samba4 is written.  Now, this hasn't been a hard and fast rule in
> Samba3, but in Samba4's prog_guide.txt the Linux kernel style has been
> specified.  (I mostly noticed the type-before-function stuff).

OK, I've tidied up the function definitions. Anything else?

-- 
James Peach | jpeach at sgi.com | SGI Australian Software Group
I don't speak for SGI.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba4-sdd-client.diff
Type: text/x-diff
Size: 33859 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20060117/b233c45f/samba4-sdd-client.bin