Need a 3.0.21b ? What to include ? What still to fix ?

[derrell at samba.org]

"Gerald (Jerry) Carter" <jerry at samba.org> writes:

> On Thu, 12 Jan 2006, derrell at samba.org wrote:
>
>> I believe that the changes to libsmbclient over the past month or so are 
>> now sufficiently tested that I'm comfortable with them going in to the 
>> release.
>
> Derrell,
>
> I can't remember.  Are these enhancements or bug fixes?

Mostly bug fixes.  A couple of minor speed improvements and enhancements as
well.  Note that some of the bug fixes were in other libsmb/ files than
libsmbclient.c.

I'd give you revision numbers, but one problem with using svk is that I have
local revision numbers that don't match svn.  Here's an edited log showing the
relevant (local) revisions to be merged:

----------------------------------------------------------------------
r12127:  derrell | 2006-01-03 15:22:18 -0500

remove old superfluous comment and ifdef
----------------------------------------------------------------------
r12122:  derrell | 2005-12-29 12:03:00 -0500

allow for arbitrary option value types
----------------------------------------------------------------------
r12115:  derrell | 2005-12-29 11:16:03 -0500

bug (enhancement) #2651: add option to log debug messages to stderr instead of stdout
----------------------------------------------------------------------
r12084:  derrell | 2005-12-29 10:05:16 -0500

do not open connection when only looking for cached connection; also, fix crash caused by missing initialization following recent locale changes
----------------------------------------------------------------------
r12083:  derrell | 2005-12-29 09:39:45 -0500

fix line length and make formatting/indentation more consistent
----------------------------------------------------------------------
r12044:  derrell | 2005-12-25 16:46:47 -0500

When enumerating what could be a server name or a workgroup name, first
check for an existing server structure.  If none exists, then go through 
the previous determination of whether it's a serrver or a workgroup.  This 
should avoid doing a NetBIOS name query each time, if we've already 
connected to the specified server.  (While we're at it, clean up indenting
and line length in this area of code.)

----------------------------------------------------------------------
r12040:  derrell | 2005-12-24 23:26:55 -0500

revert immediately previous change and fix problem correctly.  Interfaces were being loaded before all configuration files had been read.  *This* should fix byg 3336.
----------------------------------------------------------------------
r12038:  derrell | 2005-12-24 23:17:16 -0500

libsmbclient was not loading the global configuration file.  This should fix 3336.
----------------------------------------------------------------------
r12028:  derrell | 2005-12-24 20:25:38 -0500

parse dates correctly.  w_time and m_time were reversed.
----------------------------------------------------------------------
r11738:  derrell | 2005-12-14 13:15:14 -0500

Ensure that when libsmbclient copies a cli, it prevents the cli from later
being freed, by turning off the 'allocated' flag.

Change a DEBUG message in pipe_open code from level 0 to level 1 since 
libsmbclient is now regularly attempting to open a pipe for share enumeration,
and falling back to RAP if RPC is unavailable (e.g. win98).  We don't want
the debug message to display when the pipe open fails, under these normal 
circumstances.

----------------------------------------------------------------------
r11729:  derrell | 2005-12-13 22:59:45 -0500

1. Fix a crash bug which should have reared its ugly head ages ago, but for
   some reason, remained dormant until recently.  The bug pertained to
   libsmbclient doing a structure assignment of a cli after having opened a
   pipe.  The pipe open code makes a copy of the cli pointer that was passed
   to it.  If the cli is later copied (and that cli pointer that was saved
   is no longer valid), the pipe code will cause a crash during shutdown or
   when the copied cli is closed.

2. The 'type' field in enumerated shares was not being set correctly with
   the new RPC-based mechanism for enumerating shares.

----------------------------------------------------------------------
r10805:  derrell | 2005-12-07 22:34:55 -0500

first go at supporting long file names.  seeems to work; requires more testing
----------------------------------------------------------------------
r10797:  derrell | 2005-12-06 12:09:00 -0500

fixed another memory leak and reverted an (incorrect) fix from yesterday
----------------------------------------------------------------------
r10674:  derrell | 2005-12-05 13:31:28 -0500

get rid of temporary #if 0 blocks
----------------------------------------------------------------------
r10673:  derrell | 2005-12-05 13:22:34 -0500

Correct some memory and file descriptor leaks.

This should fix bugs 3257, 3267 and 3273.




-- 
democracy n.
  A product so extensively exported that the domestic supply is depleted