svn commit: samba r12850 - in branches/SAMBA_4_0/source/lib/ldb: . include

[Andrew Bartlett]

On Wed, 2006-01-11 at 11:40 -0500, simo wrote:
> On Wed, 2006-01-11 at 16:32 +0000, metze at samba.org wrote:
> > Author: metze
> > Date: 2006-01-11 16:31:57 +0000 (Wed, 11 Jan 2006)
> > New Revision: 12850
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12850
> > 
> > Log:
> > - add Doxygen comments to ldb
> > - 'make doxygen' generated the api documentation under apidocs/
> > 
> > Many thanks to Brad Hards <bradh at frogmouth.net> for the patches!
> > 
> > metze
> > Added:
> >    branches/SAMBA_4_0/source/lib/ldb/Doxyfile
> >    branches/SAMBA_4_0/source/lib/ldb/examples.dox
> >    branches/SAMBA_4_0/source/lib/ldb/mainpage.dox
> > Modified:
> >    branches/SAMBA_4_0/source/lib/ldb/
> >    branches/SAMBA_4_0/source/lib/ldb/Makefile.in
> >    branches/SAMBA_4_0/source/lib/ldb/configure.in
> >    branches/SAMBA_4_0/source/lib/ldb/include/ldb.h
> >    branches/SAMBA_4_0/source/lib/ldb/include/ldb_errors.h
> 
> 
> metze I didn't apply this patch because I was still considering the
> impact on the code.
> 
> While I found the patch valuable I also found out that some code becomes
> more difficult to be read, as an example, look at how ldb_errors.h looks
> now, it is really much more difficult to quickly list the error codes
> this way and spot the right one you should use.

I think this is a small price to pay.  

I'm a doxygen fan, and while I rarely run the tool (it needs to be made
part of the default make when found), I regularly updated code to follow
that style in Samba3.  I hope we can standardise on that format in
Samba4.

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060112/cc5b6140/attachment.bin