svn commit: samba r12850 - in
branches/SAMBA_4_0/source/lib/ldb: . include
simo
idra at samba.org
Wed Jan 11 16:40:05 GMT 2006
On Wed, 2006-01-11 at 16:32 +0000, metze at samba.org wrote:
> Author: metze
> Date: 2006-01-11 16:31:57 +0000 (Wed, 11 Jan 2006)
> New Revision: 12850
>
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12850
>
> Log:
> - add Doxygen comments to ldb
> - 'make doxygen' generated the api documentation under apidocs/
>
> Many thanks to Brad Hards <bradh at frogmouth.net> for the patches!
>
> metze
> Added:
> branches/SAMBA_4_0/source/lib/ldb/Doxyfile
> branches/SAMBA_4_0/source/lib/ldb/examples.dox
> branches/SAMBA_4_0/source/lib/ldb/mainpage.dox
> Modified:
> branches/SAMBA_4_0/source/lib/ldb/
> branches/SAMBA_4_0/source/lib/ldb/Makefile.in
> branches/SAMBA_4_0/source/lib/ldb/configure.in
> branches/SAMBA_4_0/source/lib/ldb/include/ldb.h
> branches/SAMBA_4_0/source/lib/ldb/include/ldb_errors.h
metze I didn't apply this patch because I was still considering the
impact on the code.
While I found the patch valuable I also found out that some code becomes
more difficult to be read, as an example, look at how ldb_errors.h looks
now, it is really much more difficult to quickly list the error codes
this way and spot the right one you should use.
I was going to ask Brad if there is another way to add these comments
for example.
Plus some comments are wrong imho.
Simo.
More information about the samba-technical
mailing list