[PATCH][SAMBA4] IPv6 socket fixes
Stefan (metze) Metzmacher
metze at samba.org
Tue Jan 10 06:15:52 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew Bartlett schrieb:
> It always struck me that we should be returning an IP address, not a
> reverse lookup name, when asking for the remote socket address.
yep, I also thought of this...
> Could one of the IPv6 gurus take a look at this (untested) patch?
jelmer, can you test this?
> ------------------------------------------------------------------------
>
> Index: lib/socket/socket_ipv6.c
> ===================================================================
> --- lib/socket/socket_ipv6.c (revision 12809)
> +++ lib/socket/socket_ipv6.c (working copy)
> @@ -302,7 +302,8 @@
> socklen_t len = sizeof(*peer_addr);
> struct socket_address *peer;
> int ret;
> - struct hostent *he;
> + char addr[128]
why not char addr[INET6_ADDRSTRLEN]; ?
- --
metze
Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFDw1ESm70gjA5TCD8RAvIqAJ4wXbwsx5C7wRQ/i8piqplbhWKHeQCdF0JI
uh9MbFQHLxO9hjmw/oO3kiw=
=g8Z5
-----END PGP SIGNATURE-----
More information about the samba-technical
mailing list