svn commit: samba r12695 - in branches/SAMBA_4_0/source/scripting/libjs: .

[Andrew Bartlett]

On Wed, 2006-01-04 at 11:07 +0100, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Andrew Bartlett schrieb:
> > On Tue, 2006-01-03 at 17:22 +0000, jelmer at samba.org wrote:
> >> Author: jelmer
> >> Date: 2006-01-03 17:22:19 +0000 (Tue, 03 Jan 2006)
> >> New Revision: 12695
> >>
> >> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12695
> >>
> >> Log:
> >> A dot is allowed in NetBIOS names.
> >>
> >> Modified:
> >>    branches/SAMBA_4_0/source/scripting/libjs/provision.js
> >>
> >>
> >> Changeset:
> >> Modified: branches/SAMBA_4_0/source/scripting/libjs/provision.js
> >> ===================================================================
> >> --- branches/SAMBA_4_0/source/scripting/libjs/provision.js	2006-01-03 15:40:05 UTC (rev 12694)
> >> +++ branches/SAMBA_4_0/source/scripting/libjs/provision.js	2006-01-03 17:22:19 UTC (rev 12695)
> >> @@ -481,11 +481,11 @@
> >>  }
> >>  
> >>  // Check whether a name is valid as a NetBIOS name. 
> >> -// FIXME: There are probably more constraints here
> >> +// FIXME: There are probably more constraints here. 
> >> +// crh has a paragraph on this in his book (1.4.1.1)
> >>  function valid_netbios_name(name)
> >>  {
> >>  	if (strlen(name) > 13) return false;
> >> -	if (strstr(name, ".")) return false;
> >>  	return true;
> >>  }
> > 
> > I still don't think we should allow a dot here.  It may be allowed by
> > crh's rules, but I think we are just asking for pain in Samba4 if we
> > allow it.
> > 
> > Does windows allow such a name in 'system -> computer name'?
> 
> I use 'MX.BASE' as the netbios domain name currently on my old samba3
> domain, and my windows clients work very well

But would you dare upgrade to AD with that as the netbios name?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060104/2a095b54/attachment.bin